From: Julien Grall Date: Mon, 11 Apr 2016 13:33:33 +0000 (+0100) Subject: drivers/pl011: ACPI: The interrupt should always be high level triggered X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~1283 X-Git-Url: https://dgit.raspbian.org/%22http:/www.example.com/cgi/%22https:/%22bookmarks://%22Dat/%22http:/www.example.com/cgi/%22https:/%22bookmarks:/%22Dat?a=commitdiff_plain;h=ac703c285a4fbfcb85c19364ea0c67780bf16c2d;p=xen.git drivers/pl011: ACPI: The interrupt should always be high level triggered The SPCR does not specify if the interrupt is edge or level triggered. So the configuration needs to be hardcoded in the code. Based on the PL011 TRM (see 2.2.8 in ARM DDI 0183G), the interrupt generated will be active high. Whilst the wording may be interpreted differently, the SBSA (section 4.3.2 in ARM-DEN-0029 v2.3) states the PL011 is implemented with a level triggered interrupt. So the driver should configure the interrupt as high level triggered. Signed-off-by: Julien Grall Reviewed-by: Shannon Zhao Reviewed-by: Stefano Stabellini --- diff --git a/xen/drivers/char/pl011.c b/xen/drivers/char/pl011.c index fa22edf403..1212d5cdf3 100644 --- a/xen/drivers/char/pl011.c +++ b/xen/drivers/char/pl011.c @@ -327,7 +327,7 @@ static int __init pl011_acpi_uart_init(const void *data) } /* trigger/polarity information is not available in spcr */ - irq_set_type(spcr->interrupt, IRQ_TYPE_EDGE_BOTH); + irq_set_type(spcr->interrupt, IRQ_TYPE_LEVEL_HIGH); res = pl011_uart_init(spcr->interrupt, spcr->serial_port.address, PAGE_SIZE);